On 4/16/18 1:20 PM, David Miller wrote: > From: David Ahern <dsah...@gmail.com> > Date: Mon, 16 Apr 2018 08:22:41 -0700 > >> @@ -2394,6 +2395,7 @@ static void addrconf_add_mroute(struct net_device *dev) >> .fc_ifindex = dev->ifindex, >> .fc_dst_len = 8, >> .fc_flags = RTF_UP, >> + .fc_type = RTN_UNICAST, >> .fc_nlinfo.nl_net = dev_net(dev), >> }; >> > > Multicast route is of type RTN_UNICAST? > > All of these cases where passing in a zero initialized value of > fc_type up until this patch. Perhaps you should discuss that in your > commit message a little bit.
Added this to the commit message: fc_type is set in current users based on the algorithm in rt6_fill_node: - rt6i_flags contains RTF_LOCAL: fc_type = RTN_LOCAL - rt6i_flags contains RTF_ANYCAST: fc_type = RTN_ANYCAST - else fc_type = RTN_UNICAST Similarly, fib6_type is set in the rt6_info templates based on the RTF_REJECT section of rt6_fill_node converting dst.error to RTN type. ##### Will send a v2 later this week.
