On 04/16/2018 01:50 PM, Saeed Mahameed wrote: > > Dave, Eric, I would like to know whether it is ok to have this change > in the kernel (make get_stats ndo "might sleep")? I really didn't get > any convincing feedback to not do this change.
Fact that you were not convinced does not mean you were right. I would rather not change the current behavior and risk nasty bugs. Having SNMP daemons blocked while some device is sleeping in its ndo_get_stats() is concerning, since it is currently an immediate operation. ethtool -S can definitely sleep if you need fancy stats.