On Tue, Apr 17, 2018 at 11:12 AM, Andrew Lunn <and...@lunn.ch> wrote:
> On Tue, Apr 17, 2018 at 10:04:43AM +1200, Michael Schmitz wrote:
>> From: John Paul Adrian Glaubitz <glaub...@physik.fu-berlin.de>
>> The AX88796B as installed on the X-Surf-100 does not recognize a MII reset
>> request if the previous write to the MII control register also was a reset
>> request. So a dummy write to the control register makes the soft reset in
>> the PHY initialization code work.
>> Signed-off-by: Michael Karcher <ker...@mkarcher.dialup.fu-berlin.de>
>> drivers/net/ethernet/8390/ax88796.c | 4 ++++
>> 1 files changed, 4 insertions(+), 0 deletions(-)
>> diff --git a/drivers/net/ethernet/8390/ax88796.c
>> index 6af9aca..a2f9a09 100644
>> --- a/drivers/net/ethernet/8390/ax88796.c
>> +++ b/drivers/net/ethernet/8390/ax88796.c
>> @@ -374,6 +374,10 @@ static int ax_mii_probe(struct net_device *dev)
>> return -ENODEV;
>> + /* write a non-reset pattern to the control register to
>> + * re-arm the reset request detection logic (needed on AX88796B)
>> + */
>> + phy_write(phy_dev, MII_BMCR, 0);
> This should really be fixed in the PHY driver, not the MAC.
OK - do you want this separate, or as part of this series? Might have
a few side effects on more commonly used hardware, perhaps?