On Thursday, April 19, 2018 09:34 AM, Chris Ruehl wrote:

On Thursday, April 19, 2018 09:21 AM, Chris Ruehl wrote:
On Wednesday, April 18, 2018 09:02 PM, Andrew Lunn wrote:
On Wed, Apr 18, 2018 at 02:56:01PM +0200, Andrew Lunn wrote:
On Wed, Apr 18, 2018 at 09:34:16AM +0800, Chris Ruehl wrote:

I like to get your heads up at a regression introduced in 4.9.94
commitment lead to a kernel ops and make the network unusable on my MX6DL
customized board.

Race condition resume is called on startup and the phy not yet initialized.

Hi Chris

Please could you try

bfe72442578b ("net: phy: micrel: fix crash when statistic requested for KSZ9031 phy")

I don't think it is a complete fix. I suspect "Micrel KSZ8795",
"Micrel KSZ886X Switch", "Micrel KSZ8061", and "Micrel KS8737" will
still have problems.

Those four probably need a:

         .probe          = kszphy_probe,


Indeed I have the
[    7.385851] Micrel KSZ9031 Gigabit PHY 2188000.ethernet-1:05: attached PHY driver [Micrel KSZ9031 Gigabit PHY] (mii_bus:phy_addr=2188000.ethernet-1:05, irq=-1)

first I rollback to a non crashing stable kernel.

As "bfe72442578b" gonna fix it I check with the next update and verify its works for me.



Change my mind. Find the patch you mentioned and will apply and test.



make a micro patch only and can confirm to add the .probe fix the ops.

But the imx serial is broken :-( ! have to have a look into it.

--- linux-4.9/drivers/net/phy/micrel.c.orig     2018-04-19 09:37:45.648000000 
+++ linux-4.9/drivers/net/phy/micrel.c  2018-04-19 09:44:54.356000000 +0800
@@ -974,6 +974,7 @@
        .features       = (PHY_GBIT_FEATURES | SUPPORTED_Pause),
        .flags          = PHY_HAS_MAGICANEG | PHY_HAS_INTERRUPT,
        .driver_data    = &ksz9021_type,
+       .probe          = kszphy_probe,
        .config_init    = ksz9021_config_init,
        .config_aneg    = genphy_config_aneg,
        .read_status    = genphy_read_status,
@@ -993,6 +994,7 @@
        .features       = (PHY_GBIT_FEATURES | SUPPORTED_Pause),
        .flags          = PHY_HAS_MAGICANEG | PHY_HAS_INTERRUPT,
        .driver_data    = &ksz9021_type,
+       .probe          = kszphy_probe,
        .config_init    = ksz9031_config_init,
        .config_aneg    = genphy_config_aneg,
        .read_status    = ksz9031_read_status,

[ 7.219735] Micrel KSZ9031 Gigabit PHY 2188000.ethernet-1:04: attached PHY driver [Micrel KSZ9031 Gigabit PHY] (mii_bus:phy_addr=2188000.ethernet-1:04, irq=-1)


GTSYS Limited RFID Technology
9/F, Unit E, R07, Kwai Shing Industrial Building Phase 2,
42-46 Tai Lin Pai Road, Kwai Chung, N.T., Hong Kong
Tel (852) 9079 9521

Disclaimer: https://www.gtsys.com.hk/email/classified.html

Reply via email to