On 4/18/18 9:39 PM, Alexei Starovoitov wrote:
On Wed, Apr 18, 2018 at 09:54:44AM -0700, Yonghong Song wrote:
The test_stacktrace_map is enhanced to call bpf_get_stack
in the helper to get the stack trace as well.
The stack traces from bpf_get_stack and bpf_get_stackid
are compared to ensure that for the same stack as
represented as the same hash, their ip addresses
must be the same.

Signed-off-by: Yonghong Song <y...@fb.com>

could you please add a test for bpf_get_stack() with buildid as well?
I think patch 2 implementes it correctly, but would be good to have a test for 
it.

Right. Will improve the test to cover buildid as well.

Reply via email to