On 5/2/18 1:17 AM, Ido Schimmel wrote: > Since commit 9776d32537d2 ("net: Move call_fib_rule_notifiers up in > fib_nl_newrule") it is possible to forbid the installation of > unsupported FIB rules. > > Have mlxsw return an error for non-default FIB rules in addition to the > existing extack message. > > Example: > # ip rule add from 198.51.100.1 table 10 > Error: mlxsw_spectrum: FIB rules not supported.
Next, I think we need a user override flag for rules to prevent hardware from limiting the rules that can be added and aborting offload. For example, if the user knows that a rule is meant to direct traffic out of a management VRF and is unrelated to front panel ports the offload should ignore it. > > Note that offload is only aborted when non-default FIB rules are already > installed and merely replayed during module initialization. > > Signed-off-by: Ido Schimmel <ido...@mellanox.com> > --- > drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > Acked-by: David Ahern <dsah...@gmail.com>