On Thu, May 03, 2018 at 03:06:48PM +0200, Marek Behún wrote: > The 88E6141/6341 switches (also known as Topaz) have 1 SGMII lane, > which can be configured the same way as the SERDES lane on 88E6390. > > Signed-off-by: Marek Behun <marek.be...@nic.cz>
> +int mv88e6341_serdes_power(struct mv88e6xxx_chip *chip, int port, bool on) > +{ > + int err; > + u8 cmode; > + > + if (port != 5) > + return 0; > + > + err = mv88e6xxx_port_get_cmode(chip, port, &cmode); > + if (err) > + return err; > + > + if ((cmode == MV88E6XXX_PORT_STS_CMODE_1000BASE_X) || > + (cmode == MV88E6XXX_PORT_STS_CMODE_SGMII) || > + (cmode == MV88E6XXX_PORT_STS_CMODE_2500BASEX)) > + return mv88e6390_serdes_sgmii(chip, 0x15, on); Hi Marek Please add a #define for this 0x15. Otherwise, this looks good. Andrew