David Miller <[email protected]> writes: > From: Toke Høiland-Jørgensen <[email protected]> > Date: Tue, 15 May 2018 17:12:44 +0200 > >> +typedef u64 cobalt_time_t; >> +typedef s64 cobalt_tdiff_t; > ... >> +static cobalt_time_t cobalt_get_time(void) >> +{ >> + return ktime_get_ns(); >> +} >> + >> +static u32 cobalt_time_to_us(cobalt_time_t val) >> +{ >> + do_div(val, NSEC_PER_USEC); >> + return (u32)val; >> +} > > If fundamentally you are working with ktime_t values, please use that type > and the associated helpers. > > This is a valid argument that using custom typedefs provide documentation > and an aid to understanding, but I think it doesn't serve that purpose > very well here. > > So please just use ktime_t throughout instead of this cobalt_time_t > and cobalt_tdiff_t. And then use helpers like ktime_to_us() which > properly optimize for 64-bit vs. 32-bit hosts.
Can do :) -Toke
