From: David Ahern <dsah...@gmail.com>

Commit bb0ad1987e96 ("ipv6: fib6_rules: support for match on sport, dport
and ip proto") added support for protocol and ports to FIB rules.
Update the FIB lookup tracepoint to dump the parameters.

Signed-off-by: David Ahern <dsah...@gmail.com>
---
 include/net/ip6_fib.h       |  2 ++
 include/trace/events/fib6.h | 29 ++++++++++++++++++++++-------
 net/ipv6/route.c            |  2 +-
 3 files changed, 25 insertions(+), 8 deletions(-)

diff --git a/include/net/ip6_fib.h b/include/net/ip6_fib.h
index cc70f6da8462..63fd9888f006 100644
--- a/include/net/ip6_fib.h
+++ b/include/net/ip6_fib.h
@@ -286,6 +286,8 @@ static inline void fib6_info_release(struct fib6_info *f6i)
                fib6_info_destroy(f6i);
 }
 
+int ip6_rt_type_to_error(u8 fib6_type);
+
 enum fib6_walk_state {
 #ifdef CONFIG_IPV6_SUBTREES
        FWS_S,
diff --git a/include/trace/events/fib6.h b/include/trace/events/fib6.h
index 1b8d951e3c12..b088b54d699c 100644
--- a/include/trace/events/fib6.h
+++ b/include/trace/events/fib6.h
@@ -19,7 +19,7 @@ TRACE_EVENT(fib6_table_lookup,
 
        TP_STRUCT__entry(
                __field(        u32,    tb_id           )
-
+               __field(        int,    err             )
                __field(        int,    oif             )
                __field(        int,    iif             )
                __field(        __u8,   tos             )
@@ -27,7 +27,10 @@ TRACE_EVENT(fib6_table_lookup,
                __field(        __u8,   flags           )
                __array(        __u8,   src,    16      )
                __array(        __u8,   dst,    16      )
-
+               __field(        u16,    sport           )
+               __field(        u16,    dport           )
+               __field(        u8,     proto           )
+               __field(        u8,     rt_type         )
                __dynamic_array(        char,   name,   IFNAMSIZ )
                __array(                __u8,   gw,     16       )
        ),
@@ -36,6 +39,7 @@ TRACE_EVENT(fib6_table_lookup,
                struct in6_addr *in6;
 
                __entry->tb_id = table->tb6_id;
+               __entry->err = ip6_rt_type_to_error(f6i->fib6_type);
                __entry->oif = flp->flowi6_oif;
                __entry->iif = flp->flowi6_iif;
                __entry->tos = ip6_tclass(flp->flowlabel);
@@ -48,10 +52,20 @@ TRACE_EVENT(fib6_table_lookup,
                in6 = (struct in6_addr *)__entry->dst;
                *in6 = flp->daddr;
 
+               __entry->proto = flp->flowi6_proto;
+               if (__entry->proto == IPPROTO_TCP ||
+                   __entry->proto == IPPROTO_UDP) {
+                       __entry->sport = ntohs(flp->fl6_sport);
+                       __entry->dport = ntohs(flp->fl6_dport);
+               } else {
+                       __entry->sport = 0;
+                       __entry->dport = 0;
+               }
+
                if (f6i->fib6_nh.nh_dev) {
                        __assign_str(name, f6i->fib6_nh.nh_dev);
                } else {
-                       __assign_str(name, "");
+                       __assign_str(name, "-");
                }
                if (f6i == net->ipv6.fib6_null_entry) {
                        struct in6_addr in6_zero = {};
@@ -65,10 +79,11 @@ TRACE_EVENT(fib6_table_lookup,
                }
        ),
 
-       TP_printk("table %3u oif %d iif %d src %pI6c dst %pI6c tos %d scope %d 
flags %x ==> dev %s gw %pI6c",
-                 __entry->tb_id, __entry->oif, __entry->iif,
-                 __entry->src, __entry->dst, __entry->tos, __entry->scope,
-                 __entry->flags, __get_str(name), __entry->gw)
+       TP_printk("table %3u oif %d iif %d proto %u %pI6c/%u -> %pI6c/%u tos %d 
scope %d flags %x ==> dev %s gw %pI6c err %d",
+                 __entry->tb_id, __entry->oif, __entry->iif, __entry->proto,
+                 __entry->src, __entry->sport, __entry->dst, __entry->dport,
+                 __entry->tos, __entry->scope, __entry->flags,
+                 __get_str(name), __entry->gw, __entry->err)
 );
 
 #endif /* _TRACE_FIB6_H */
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index cc24ed3bc334..ae27e57c5997 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -897,7 +897,7 @@ static const int fib6_prop[RTN_MAX + 1] = {
        [RTN_XRESOLVE]  = -EINVAL,
 };
 
-static int ip6_rt_type_to_error(u8 fib6_type)
+int ip6_rt_type_to_error(u8 fib6_type)
 {
        return fib6_prop[fib6_type];
 }
-- 
2.11.0

Reply via email to