Or Gerlitz <[EMAIL PROTECTED]> wrote:
[...]
>Looking on the sysconfig package, some tools eg /sbin/if{up,down,status}
>use ifenslave which is in turn provided by the iputils package.
>
>My understanding is that changing ifenslave and the bonding kernel code to
>allow for enslaving while master is not up is enough, so actually no
>change is needed to the sysconfig tools, correct?
Incorrect. The /sbin/ifup included with sysconfig (I'm looking
at version 0.31-0-15.51) has logic to set the bonding master device up
prior to adding any slaves. E.g.,
# get up the bonding device before enslaving
# if ! is_iface_up $INTERFACE; then
ip link set $INTERFACE up 2>&1
# fi
# enslave available slave devices; if there is none -> hard
break and log
MESSAGE=`/sbin/ifenslave $BONDING_OPTIONS $INTERFACE
$BSINTERFACES 2>&1`
For your purposes, this would cause it to register as an
ethernet hardware type, not an IB type. The /sbin/ifup included with
initscripts operates a little differently, but also sets the bonding
master up prior to adding any slaves.
>I have now removed the two assertions in the bonding code on enslaving
>while master is not up and manage to work fine with IPoIB slave devices
>and ***without*** the two module params!
>
>When you have the most troublesome to deploy, the troubles you refer to is
>make sure that the distros would include ***both*** the bonding kernel
>changes and use an iputils package which has the ifenslave changes?
Yes. Part of the difficulty is that the changes to the
initscripts and sysconfig packages won't be compatible with versions of
bonding prior to the bonding kernel changes (because older versions of
bonding will refuse to add slaves if the master is down). It might
require adding another API version to bonding, and modifying ifenslave
to work both ways (i.e., with the current "enslave with master up" API,
as well as the new "enslave with master down" API).
>> Yes, ifenslave is still supported. It probably will be
>> obsoleted some day (or replaced with a script that uses sysfs), but not
>> anytime soon. As far as I know, all current distros use ifenslave to
>> configure bonding.
>
>Cool, thanks for bringing this into my attention... I understand now my
>patch set should also handle the ifenslave.c source that comes with the
>kernel (eg to allow for not setting the hw address etc)
An alternate approach would be to undertake the more substantial
task of converting the initscripts and sysconfig code to use sysfs to
configure bonding. This would permit changing the logic (to add slaves
while the bonding master is down, then set it up), as well as remove the
current hacks (present only in sysconfig) to load the bonding module
once per configured bonding interface. The initscripts currently don't
do this (as far as I know), so it's generally only possible to have one
bonding interface under initscripts control.
In this case, ifenslave would continue to work as it does now,
and would simply not be supported for the new hardware.
-J
---
-Jay Vosburgh, IBM Linux Technology Center, [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
