On 5/20/18 2:15 AM, Jiri Pirko wrote: > From: Jiri Pirko <j...@mellanox.com> > > Signed-off-by: Jiri Pirko <j...@mellanox.com> > --- > devlink/devlink.c | 6 ++++++ > include/uapi/linux/devlink.h | 2 ++ > 2 files changed, 8 insertions(+) > > diff --git a/devlink/devlink.c b/devlink/devlink.c > index df2c66dac1c7..b0ae17767dab 100644 > --- a/devlink/devlink.c > +++ b/devlink/devlink.c > @@ -1737,9 +1737,15 @@ static void pr_out_port(struct dl *dl, struct nlattr > **tb) > > pr_out_str(dl, "flavour", port_flavour_name(port_flavour)); > } > + if (tb[DEVLINK_ATTR_PORT_NUMBER]) > + pr_out_uint(dl, "number", > + mnl_attr_get_u32(tb[DEVLINK_ATTR_PORT_NUMBER]));
"number" is a label means nothing. "port" is more descriptive. # ./devlink port pci/0000:03:00.0/1: type eth netdev swp17 flavour physical number 17 pci/0000:03:00.0/3: type eth netdev swp18 flavour physical number 18 pci/0000:03:00.0/5: type eth netdev swp19 flavour physical number 19 pci/0000:03:00.0/7: type eth netdev swp20 flavour physical number 20 pci/0000:03:00.0/9: type eth netdev swp21 flavour physical number 21 ... pci/0000:03:00.0/61: type eth netdev swp1s0 flavour physical number 1 split_group 1 subport 0 pci/0000:03:00.0/62: type eth netdev swp1s1 flavour physical number 1 split_group 1 subport 1