> On May 29, 2018, at 1:58 AM, Sergei Shtylyov
> <[email protected]> wrote:
>
> Hello!
>
> On 5/29/2018 12:36 AM, Song Liu wrote:
>
>> Check sch_direct_xmit() at the end of sch_direct_xmit() will be bypassed.
>
> "Checking netif_xmit_frozen_or_stopped()", perhaps? Else it doesn't make
> much sense...
Thanks Sergei!
Sending v2 with fix.
Song
>
>> This is because "ret" from sch_direct_xmit() will be either NETDEV_TX_OK
>> or NETDEV_TX_BUSY, and only ret == NETDEV_TX_OK == 0 will reach the
>> condition:
>> if (ret && netif_xmit_frozen_or_stopped(txq))
>> return false;
>> This patch cleans up the code by removing the whole condition.
>> For more discussion about this, please refer to
>> https://marc.info/?t=152727195700008
>> Signed-off-by: Song Liu <[email protected]>
>> Cc: John Fastabend <[email protected]>
>> Cc: Alexei Starovoitov <[email protected]>
>> Cc: David S. Miller <[email protected]>
> [...]
>
> MBR, Sergei
