On 29 May 2018 at 20:44, Daniel Borkmann <dan...@iogearbox.net> wrote: > On 05/29/2018 08:27 PM, Song Liu wrote: >> On Tue, May 29, 2018 at 4:27 AM, Quentin Monnet >> <quentin.mon...@netronome.com> wrote: >>> These are minor edits for the eBPF helpers documentation in >>> include/uapi/linux/bpf.h. >>> >>> The main fix consists in removing "BPF_FIB_LOOKUP_", because it ends >>> with a non-escaped underscore that gets interpreted by rst2man and >>> produces the following message in the resulting manual page: >>> >>> DOCUTILS SYSTEM MESSAGES >>> System Message: ERROR/3 (/tmp/bpf-helpers.rst:, line 1514) >>> Unknown target name: "bpf_fib_lookup". >>> >>> Other edits consist in: >>> >>> - Improving formatting for flag values for "bpf_fib_lookup()" helper. >>> - Emphasising a parameter name in description of the return value for >>> "bpf_get_stack()" helper. >>> - Removing unnecessary blank lines between "Description" and "Return" >>> sections for the few helpers that would use it, for consistency. >>> >>> Signed-off-by: Quentin Monnet <quentin.mon...@netronome.com> > [...] >> >> Please also apply the same changes to tools/include/uapi/linux/bpf.h.
Ah, true, I forgot it... Thanks for the reminder. > Just did while applying to bpf-next, thanks guys! > >> Other than this, it looks to me. >> >> Acked-by: Song Liu <songliubrav...@fb.com> Thanks a lot Song, Daniel! Quentin
