Hi Tejaswi, Thank you for the patch! Yet something to improve:
[auto build test ERROR on net/master] url: https://github.com/0day-ci/linux/commits/Tejaswi-Tanikella/ipv4-igmp-use-alarmtimer-to-prevent-delayed-reports/20180611-195615 config: i386-randconfig-x012-201823 (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 Note: the linux-review/Tejaswi-Tanikella/ipv4-igmp-use-alarmtimer-to-prevent-delayed-reports/20180611-195615 HEAD 20987eecc3144eb22578baea09ff017ddcb45163 builds fine. It only hurts bisectibility. All errors (new ones prefixed by >>): net//ipv4/igmp.c: In function 'igmp_start_timer': >> net//ipv4/igmp.c:213:19: error: implicit declaration of function >> 'jiffies_to_ktime'; did you mean 'jiffies_to_timeval'? >> [-Werror=implicit-function-declaration] ktime_t expiry = jiffies_to_ktime(prandom_u32() % max_delay + 2); ^~~~~~~~~~~~~~~~ jiffies_to_timeval net//ipv4/igmp.c: In function 'igmp_mod_timer': net//ipv4/igmp.c:250:7: error: implicit declaration of function 'ktime_to_jiffies'; did you mean 'timeval_to_jiffies'? [-Werror=implicit-function-declaration] if (ktime_to_jiffies(expiry) < max_delay) { ^~~~~~~~~~~~~~~~ timeval_to_jiffies cc1: some warnings being treated as errors vim +213 net//ipv4/igmp.c 209 210 /* It must be called with locked im->lock */ 211 static void igmp_start_timer(struct ip_mc_list *im, int max_delay) 212 { > 213 ktime_t expiry = jiffies_to_ktime(prandom_u32() % max_delay + > 2); 214 215 im->tm_running = 1; 216 alarm_start_relative(&im->alarm, expiry); 217 refcount_inc(&im->refcnt); 218 } 219 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
