The fix seems to work, but the use of kstrtoul():

        ret = kstrtoul(eq, 10, &derrno);

is incorrect since the buffer can't been modified to block out the next
argument if there is one, so the following fails:

        perl -e 'print "#dnserror=1#", "\x00" x 1' |
        keyctl padd dns_resolver desc @s

(Note this is preexisting and nothing to do with your patch).

I'm not sure how best to handle this.

Anyway, Dave, can you take Eric's patch into the net tree with:

        Acked-by: David Howells <dhowe...@redhat.com>

David

Reply via email to