On 06/14/2018 11:33 AM, Jesper Dangaard Brouer wrote: > On Thu, 14 Jun 2018 18:00:22 +0900 > Toshiaki Makita <[email protected]> wrote: >> On 2018/06/14 17:49, Jesper Dangaard Brouer wrote: >>> On Thu, 14 Jun 2018 11:07:42 +0900 >>> Toshiaki Makita <[email protected]> wrote: >>> >>>> Commit 67f29e07e131 ("bpf: devmap introduce dev_map_enqueue") changed >>>> the return value type of __devmap_lookup_elem() from struct net_device * >>>> to struct bpf_dtab_netdev * but forgot to modify generic XDP code >>>> accordingly. >>>> Thus generic XDP incorrectly used struct bpf_dtab_netdev where struct >>>> net_device is expected, then skb->dev was set to invalid value. >>>> >>>> v2: >>>> - Fix compiler warning without CONFIG_BPF_SYSCALL. >>>> >>>> Fixes: 67f29e07e131 ("bpf: devmap introduce dev_map_enqueue") >>>> Signed-off-by: Toshiaki Makita <[email protected]> >>> >>> Thanks for catching this! >>> >>> Acked-by: Jesper Dangaard Brouer <[email protected]>
Applied to bpf, thanks Toshiaki!
