On Mon, Jul 2, 2018 at 11:05 PM, David Ahern <dsah...@gmail.com> wrote:
> On 7/2/18 12:30 AM, Xin Long wrote:
>> @@ -2143,6 +2149,10 @@ static int devinet_conf_proc(struct ctl_table *ctl,
>> int write,
>> if ((new_value == 0) && (old_value != 0))
>> rt_cache_flush(net);
>>
>> + if (i == IPV4_DEVCONF_BC_FORWARDING - 1 ||
>> + new_value != old_value)
>> + rt_cache_flush(net);
>> +
>
> Shouldn't that be '&&' instead of '||' otherwise you are bumping the fib
> gen id any time the old and new values do not equal regardless of which
> setting is changed.
ah right, It's a copy-paste mistake, sorry
