On 07/07/2018 01:26 AM, Santosh Shilimkar wrote:
Hi Ka-Cheong,
On 7/6/2018 8:25 AM, Sowmini Varadhan wrote:
On (07/06/18 23:08), Ka-Cheong Poon wrote:
As mentioned in a previous mail, it is unclear why the
port number is transport specific. Most Internet services
use the same port number running over TCP/UDP as shown
in the IANA database. And the IANA RDS registration is
the same. What is the rationale of having a transport
specific number in the RDS implementation?
because not every transport may need a port number.
Lets keep separate port for RDMA and TCP transport. This has been
already useful for wireshark dissector and can also help for eBPF
like external tooling. The fragment format and re-assembly is
different across transports.
But does it have anything to do with the fact that a #define
is in the rds.h file?
I do see your point and also agree that port number isn't transport
specific and in case we need to add another transport, what port
to use. But may be till then lets keep the existing behavior.
As such this port switch is not related to IPv6 support as such
so lets deal with it separately.
As I mentioned in a previous mail, I can move the #define if
it makes folks happy. But the number cannot be changed as it
is already being used.
--
K. Poon
ka-cheong.p...@oracle.com
