From: Boris Pismenny <bor...@mellanox.com> Date: Thu, 12 Jul 2018 22:25:57 +0300
> We currently have no devices that support both TLS and IPsec using the > accel framework, and the current code does not support both IPsec and > TLS. This patch prevents such combinations. > > Signed-off-by: Boris Pismenny <bor...@mellanox.com> > --- > drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig > b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig > index 2545296..d3e8c70 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig > +++ b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig > @@ -93,6 +93,7 @@ config MLX5_EN_TLS > depends on TLS_DEVICE > depends on TLS=y || MLX5_CORE=m > depends on MLX5_ACCEL > + depends on !MLX5_EN_IPSEC > default n You absolutely cannot do this. You are forcing a distribution to pick one offload or the other at build time, that's insane. Please find a way to support both offloads in the driver. It is absolutely valid for a distribution to ship the driver in a state that supports both offloads and you must therefore support this properly. Thank you.
