Removed checks against non-NULL before calling kfree_skb() and
crypto_free_aead(). These functions are safe to be called with NULL
as an argument.

Signed-off-by: Vakul Garg <vakul.g...@nxp.com>
---
 net/tls/tls_sw.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/net/tls/tls_sw.c b/net/tls/tls_sw.c
index 0c2d029c9d4c..ef445478239c 100644
--- a/net/tls/tls_sw.c
+++ b/net/tls/tls_sw.c
@@ -1044,8 +1044,7 @@ void tls_sw_free_resources_tx(struct sock *sk)
        struct tls_context *tls_ctx = tls_get_ctx(sk);
        struct tls_sw_context_tx *ctx = tls_sw_ctx_tx(tls_ctx);
 
-       if (ctx->aead_send)
-               crypto_free_aead(ctx->aead_send);
+       crypto_free_aead(ctx->aead_send);
        tls_free_both_sg(sk);
 
        kfree(ctx);
@@ -1057,10 +1056,8 @@ void tls_sw_release_resources_rx(struct sock *sk)
        struct tls_sw_context_rx *ctx = tls_sw_ctx_rx(tls_ctx);
 
        if (ctx->aead_recv) {
-               if (ctx->recv_pkt) {
-                       kfree_skb(ctx->recv_pkt);
-                       ctx->recv_pkt = NULL;
-               }
+               kfree_skb(ctx->recv_pkt);
+               ctx->recv_pkt = NULL;
                crypto_free_aead(ctx->aead_recv);
                strp_stop(&ctx->strp);
                write_lock_bh(&sk->sk_callback_lock);
-- 
2.13.6

Reply via email to