Re: [PATCH net-next v3 1/5] tc/act: user space can't use TC_ACT_REDIRECT directly

[Jamal Hadi Salim]

On 24/07/18 04:06 PM, Paolo Abeni wrote:

--- a/net/sched/act_api.c
+++ b/net/sched/act_api.c
@@ -895,6 +895,11 @@ struct tc_action *tcf_action_init_1(struct net *net, 
struct tcf_proto *tp,
                }
        }

+ if (a->tcfa_action == TC_ACT_REDIRECT) {

+               net_warn_ratelimited("TC_ACT_REDIRECT can't be used directly");
+               a->tcfa_action = TC_ACT_UNSPEC;
+       }
+

Why not just reject the rule instead of changing the code underneath the
user?

cheers,
jamal