From: Saeed Mahameed <sae...@mellanox.com>
Date: Fri, 10 Aug 2018 15:26:19 -0700
> +static int validate_tcpudp4(struct ethtool_rx_flow_spec *fs)
> +{
> + struct ethtool_tcpip4_spec *l4_mask = &fs->m_u.tcp_ip4_spec;
> + int ntuples = 0;
> +
> + if (fs->m_u.tcp_ip4_spec.tos)
^^^^^^^^^^^^^^^^^^^^^^^^
Since you've gone to the trouble of loading this object into
l4_mask before this statement, please use "if (l4_mask->tos)"
I know you're just moving existing code into a function, but it
looks silly now.
