On 2018-09-06 6:28 a.m., Jamal Hadi Salim wrote:
On 2018-09-05 3:04 p.m., Al Viro wrote:
From: Al Viro <v...@zeniv.linux.org.uk>
... and disallow deleting or linking to such
Signed-off-by: Al Viro <v...@zeniv.linux.org.uk>
Same comment as other one in regards to subject
Since the flag space is coming from htnode which is
exposed via uapi it makes sense to keep this one here
because it is for private use; but a comment in
include/uapi/linux/pkt_cls.h that this flag or
maybe a set of bits is reserved for internal use.
Otherwise:
Acked-by: Jamal Hadi Salim <j...@mojatatu.com>
Sorry, additional comment:
It makes sense to reject user space attempt to
set TCA_CLS_FLAGS_U32_ROOT
So my suggestion is to update tc_flags_valid() to
check for this.
cheers,
jamal
