Please correct me if I'm wrong, but... It looks like Eran's proposed fix would remove all warning and alarm indications from ethtool's output. It's worth mentioning that for me, the following fields always reported correctly as Off while no alarm condition was present and On while alarm condition(s) were present *per the QSFP's true/programmed threshold values* *not per the incorrectly reported threshold values*
Laser bias current high alarm (Chan 1) : Off Laser bias current low alarm (Chan 1) : Off Laser bias current high warning (Chan 1) : Off Laser bias current low warning (Chan 1) : Off Laser bias current high alarm (Chan 2) : Off Laser bias current low alarm (Chan 2) : Off Laser bias current high warning (Chan 2) : Off Laser bias current low warning (Chan 2) : Off Laser bias current high alarm (Chan 3) : Off Laser bias current low alarm (Chan 3) : Off Laser bias current high warning (Chan 3) : Off Laser bias current low warning (Chan 3) : Off Laser bias current high alarm (Chan 4) : Off Laser bias current low alarm (Chan 4) : Off Laser bias current high warning (Chan 4) : Off Laser bias current low warning (Chan 4) : Off Module temperature high alarm : Off Module temperature low alarm : Off Module temperature high warning : Off Module temperature low warning : Off Module voltage high alarm : Off Module voltage low alarm : Off Module voltage high warning : Off Module voltage low warning : Off Laser tx power high alarm (Channel 1) : Off Laser tx power low alarm (Channel 1) : Off Laser tx power high warning (Channel 1) : Off Laser tx power low warning (Channel 1) : Off Laser tx power high alarm (Channel 2) : Off Laser tx power low alarm (Channel 2) : Off Laser tx power high warning (Channel 2) : Off Laser tx power low warning (Channel 2) : Off Laser tx power high alarm (Channel 3) : Off Laser tx power low alarm (Channel 3) : Off Laser tx power high warning (Channel 3) : Off Laser tx power low warning (Channel 3) : Off Laser tx power high alarm (Channel 4) : Off Laser tx power low alarm (Channel 4) : Off Laser tx power high warning (Channel 4) : Off Laser tx power low warning (Channel 4) : Off Laser rx power high alarm (Channel 1) : Off Laser rx power low alarm (Channel 1) : Off Laser rx power high warning (Channel 1) : Off Laser rx power low warning (Channel 1) : Off Laser rx power high alarm (Channel 2) : Off Laser rx power low alarm (Channel 2) : Off Laser rx power high warning (Channel 2) : Off Laser rx power low warning (Channel 2) : Off Laser rx power high alarm (Channel 3) : Off Laser rx power low alarm (Channel 3) : Off Laser rx power high warning (Channel 3) : Off Laser rx power low warning (Channel 3) : Off Laser rx power high alarm (Channel 4) : Off Laser rx power low alarm (Channel 4) : Off Laser rx power high warning (Channel 4) : Off Laser rx power low warning (Channel 4) : Off I would like to request that any fix keeps the above information included in the ethtool -m output because it is working and valuable. The only values that report incorrectly can be seen by issuing the command: ethtool -m interfaceXXX | grep threshold Ideally, any fix would display the thresholds correctly instead of omit them. Thank you and best regards, Chris