> +static int load_iso3166_1(void) {
> + int r = 0;
> + r |= iso3166_1_add(4, "AF", "AFG",
> + "Afghanistan");
[...]
Why don't you make the table a static array, then you can use ARRAY_SIZE
and get rid of the whole list_head, not have it eat up code size and
mark it as read-only static data.
> +EXPORT_SYMBOL(iso3166_1_list);
Why export the list?
> +EXPORT_SYMBOL(get_iso3166_1_numeric);
> +EXPORT_SYMBOL(get_iso3166_1_alpha2);
> +EXPORT_SYMBOL(get_iso3166_1_alpha3);
> +EXPORT_SYMBOL(iso3166_1_exists);
Also, please put these along with the function.
johannes
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
