Hi Ariel, I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Ariel-Elior/qed-Doorbell-overflow-recovery/20181022-212749 config: i386-randconfig-x005-201842 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All error/warnings (new ones prefixed by >>): In file included from drivers/net/ethernet/qlogic/qed/qed_dev.c:47:0: drivers/net/ethernet/qlogic/qed/qed_dev.c: In function 'qed_db_recovery_ring': >> include/linux/qed/qed_if.h:466:40: error: implicit declaration of function >> 'writeq'; did you mean 'writel'? [-Werror=implicit-function-declaration] #define DIRECT_REG_WR64(reg_addr, val) writeq((u32)val, \ ^ >> drivers/net/ethernet/qlogic/qed/qed_dev.c:342:4: note: in expansion of macro >> 'DIRECT_REG_WR64' DIRECT_REG_WR64(db_entry->db_addr, ^~~~~~~~~~~~~~~ cc1: some warnings being treated as errors -- In file included from drivers/net//ethernet/qlogic/qed/qed_dev.c:47:0: drivers/net//ethernet/qlogic/qed/qed_dev.c: In function 'qed_db_recovery_ring': >> include/linux/qed/qed_if.h:466:40: error: implicit declaration of function >> 'writeq'; did you mean 'writel'? [-Werror=implicit-function-declaration] #define DIRECT_REG_WR64(reg_addr, val) writeq((u32)val, \ ^ drivers/net//ethernet/qlogic/qed/qed_dev.c:342:4: note: in expansion of macro 'DIRECT_REG_WR64' DIRECT_REG_WR64(db_entry->db_addr, ^~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +466 include/linux/qed/qed_if.h 465 > 466 #define DIRECT_REG_WR64(reg_addr, val) writeq((u32)val, \ 467 (void __iomem *)(reg_addr)) 468 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
