On 08.11.2018 19:37, Andrew Lunn wrote:
>> {
>> .phy_id = 0x00008201,
>> .name = "RTL8201CP Ethernet",
>> - .phy_id_mask = 0x0000ffff,
>> .features = PHY_BASIC_FEATURES,
>> .flags = PHY_HAS_INTERRUPT,
>> }, {
>> .phy_id = 0x001cc816,
>> .name = "RTL8201F Fast Ethernet",
>> - .phy_id_mask = 0x001fffff,
>
> Hi Heiner
>
> "RTL8201CP Ethernet" has a mask of 0x0000ffff, where as all the others
> use 0x001fffff. Is this correct?
>
IMO none of the masks is correct. All of them should be 0xffffffff.
Nowadays the 32 bit PHYID is assembled from (MSB to LSB):
22 bits vendor OUI, 6 bit model number, 4 bit revision number
Just the old 8201 doesn't follow this scheme.
With the current masks, a PHYID 0x12348201 would be recognized as
Realtek 8201 too, what's obviously wrong.
> Andrew
>
