On Thu, Nov 8, 2018 at 12:14 PM Stefano Brivio <sbri...@redhat.com> wrote: > > On Thu, 8 Nov 2018 12:02:00 -0800 > Cong Wang <xiyou.wangc...@gmail.com> wrote: > > > On Thu, Nov 8, 2018 at 11:54 AM Stefano Brivio <sbri...@redhat.com> wrote: > > > > > > Hi, > > > > > > On Thu, 8 Nov 2018 11:49:49 -0800 > > > Cong Wang <xiyou.wangc...@gmail.com> wrote: > > > > > > > +EXPORT_SYMBOL(__skb_checksum_complete); > > > > + > > > > /* Both of above in one bottle. */ > > > > > > Maybe you should also update/drop this comment now? > > > > I have no idea what that comment means. Do you? > > I think it refers to the fact that skb_copy_and_csum_bits() implements > both skb_checksum() and skb_copy_bits(), that were just above it at > 1da177e4c3f4. > > Then more stuff was moved in between, and the comment was never updated > or dropped.
I don't want to touch what I don't understand. So, let me just move these two after skb_copy_and_csum_bits().
