On Thu, Nov 8, 2018 at 2:17 PM Eric Dumazet <[email protected]> wrote: > > On Thu, Nov 8, 2018 at 2:04 PM Cong Wang <[email protected]> wrote: > > > > When subtracting the checksum of a block of data, > > csum_block_sub() must be used to respect the offset. > > > > We learned this lesson from both commit d55bef5059dd > > ("net: fix pskb_trim_rcsum_slow() with odd trim offset") and > > commit d48051c5b837 ("net/mlx5e: fix csum adjustments caused by RXFCS"). > > > > Fixes: ca4ef4574f1e ("ip: fix IP_CHECKSUM handling") > > I do not believe you fix any bug here... > > I do not know of any inet protocol having odd header sizes.
That offset is payload offset, but yeah, the payload offset must be aligned some way. Good point! Let's drop it.
