On 11/9/2018 11:14 PM, Jiri Pirko wrote: > Sat, Nov 10, 2018 at 01:11:10AM CET, amritha.namb...@intel.com wrote: > > [...] > >> @@ -1026,8 +1122,7 @@ static void fl_init_dissector(struct flow_dissector >> *dissector, >> FLOW_DISSECTOR_KEY_IPV4_ADDRS, ipv4); >> FL_KEY_SET_IF_MASKED(mask, keys, cnt, >> FLOW_DISSECTOR_KEY_IPV6_ADDRS, ipv6); >> - FL_KEY_SET_IF_MASKED(mask, keys, cnt, >> - FLOW_DISSECTOR_KEY_PORTS, tp); >> + FL_KEY_SET(keys, cnt, FLOW_DISSECTOR_KEY_PORTS, tp); > > You still need to set the key under a condition. Something like: > if (FL_KEY_IS_MASKED(mask, tp) || > FL_KEY_IS_MASKED(mask, tp_min) || > FL_KEY_IS_MASKED(mask, tp_max) > FL_KEY_SET(keys, cnt, FLOW_DISSECTOR_KEY_PORTS, tp); >
Yes, will do. Thanks! > >> FL_KEY_SET_IF_MASKED(mask, keys, cnt, >> FLOW_DISSECTOR_KEY_IP, ip); >> FL_KEY_SET_IF_MASKED(mask, keys, cnt, > > [...] >
