On Tue, Nov 20, 2018 at 10:18:17AM -0800, Eric Dumazet wrote: > > > Something like this? Is it safe to linearize here?
It looks safe to me. It's only unsafe if your skb is shared which from my grepping does not appear to be the case (and it cannot be shared if you're modifying skb->csum which all the callers that I found were doing for obvious reasons). If it's cloned skb_linearize will unclone it. > I guess we should dump from skb->head instead, to show all headers. > > Maybe dump the mac header offset as well, so that we can ignore the > padding bytes (NET_SKB_PAD) if needed. Yes I agree. It doesn't hurt to dump more data. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
