Re: [sungem] proposal for a new locking strategy

[Eric Lemoine]

You could also just use net_tx_lock() now.

You mean netif_tx_lock()?

Thanks for letting me know about that function. Yes, I may need it.
tg3 and bnx2 use it to wake up the transmit queue:

        if (unlikely(netif_queue_stopped(tp->dev) &&
                     (tg3_tx_avail(tp) > TG3_TX_WAKEUP_THRESH))) {
                netif_tx_lock(tp->dev);
                if (netif_queue_stopped(tp->dev) &&
                    (tg3_tx_avail(tp) > TG3_TX_WAKEUP_THRESH))
                        netif_wake_queue(tp->dev);
                netif_tx_unlock(tp->dev);
        }

2.6.17 didn't use it. Was it a bug?

Thanks,
--
Eric
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html