From: Matteo Croce <mcr...@redhat.com> Date: Tue, 4 Dec 2018 18:05:42 +0100
> Following commit 59f997b088d2 ("macvlan: return correct error value"), > there is a duplicate check for mac addresses both in macvlan_sync_address() > and macvlan_set_mac_address(). > As the former calls the latter, remove the one in macvlan_set_mac_address() > and move the one in macvlan_sync_address() before any other check. > > Signed-off-by: Matteo Croce <mcr...@redhat.com> Hmmm, doesn't this change behavior? For the handling of the NETDEV_CHANGEADDR event in macvlan_device_event() we would make it to macvlan_sync_address(), and if IFF_UP is false, we would elide the macvlan_addr_busy() check and just copy the MAC addres over and return. Now, we would always perform the macvlan_addr_busy() check. Please, if this is OK, explain and document this behavioral chance in the commit message. Thank you.