> -----Original Message----- > From: Intel-wired-lan [mailto:[email protected]] On > Behalf Of Ross Lagerwall > Sent: Wednesday, December 5, 2018 5:54 AM > To: [email protected]; [email protected] > Cc: Ross Lagerwall <[email protected]>; David S. Miller > <[email protected]> > Subject: [Intel-wired-lan] [PATCH] ixgbe: Fix race when the VF driver does a > reset > > When the VF driver does a reset, it (at least the Linux one) writes to the > VFCTRL register to issue a reset and then immediately sends a reset message > using the mailbox API. This is racy because when the PF driver detects that > the VFCTRL register reset pin has been asserted, it clears the mailbox > memory. Depending on ordering, the reset message sent by the VF could be > cleared by the PF driver. It then responds to the cleared message with a > NACK which causes the VF driver to malfunction. > Fix this by deferring clearing the mailbox memory until the reset message is > received. > > Fixes: 939b701ad633 ("ixgbe: fix driver behaviour after issuing VFLR") > Signed-off-by: Ross Lagerwall <[email protected]> > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-)
Tested-by: Andrew Bowers <[email protected]>
