* Eric Dumazet <[EMAIL PROTECTED]> 2006-11-09 14:23
> I give a big NACK to this patch.
> 
> By moving fwmark outside of union, you basically touch more cache lines in 
> lookups. I have many machines doing XX.XXX of lookups per second, with long 
> chains, already using 10% of CPU. I am sure a lot of other machines would 
> suffer with this patch, especially machines with 32 bytes cache lines.
> 
> For IPV4 lookups, compare offset of fwmark before your patch and after.
> The size of ip6_u is so large that moving fwmark after nl_u union is not an 
> option. Many packets in flight on the Internet are still IPV4.

Would you be happy if mark is moved in front of the union after iif?
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to