From: "Leigh Brown" <[EMAIL PROTECTED]>
Date: Tue, 12 Dec 2006 23:03:34 -0000 (GMT)
> Well, the inline functions seem okay in that regard, but I'll bow to
> your superior judgement.
I think we're still not onto the right fix.
I took a look, and the issue seems to simply be that the
__tcp_put_md5sig_pool() is not doing the reference count
thing that __tcp_get_md5sig_pool() does (via tcp_md5sig_users).
The direct call to __tcp_free_md5sig_pool() seems to be
what causes this problem, we should be invoking
tcp_free_md5sig_pool() instead.
Can you give this patch a try? Thanks.
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index 090c690..4c57019 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -2364,8 +2364,9 @@ struct tcp_md5sig_pool *__tcp_get_md5sig
EXPORT_SYMBOL(__tcp_get_md5sig_pool);
-void __tcp_put_md5sig_pool(void) {
- __tcp_free_md5sig_pool(tcp_md5sig_pool);
+void __tcp_put_md5sig_pool(void)
+{
+ tcp_free_md5sig_pool(tcp_md5sig_pool);
}
EXPORT_SYMBOL(__tcp_put_md5sig_pool);
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
