On Thu, 31 Jan 2019 09:25:08 -0800, Jakub Kicinski wrote:
> On Thu, 31 Jan 2019 09:23:03 -0800 (PST), David Miller wrote:
> > From: kbuild test robot <l...@intel.com>
> > Date: Fri, 1 Feb 2019 00:19:33 +0800
> >
> > > All errors (new ones prefixed by >>):
> > >
> > > m68k-linux-gnu-ld: drivers/rtc/proc.o: in function
> > > `is_rtc_hctosys.isra.0':
> > > proc.c:(.text+0x178): undefined reference to `strcmp'
> > > m68k-linux-gnu-ld: net/core/ethtool.o: in function
> > > `ethtool_get_drvinfo':
> > >>> ethtool.c:(.text+0xc08): undefined reference to
> > >>> `devlink_compat_running_version'
> >
> > Missing string.h include perhaps?
>
> Yeah, that one looks like existing m68k bug, but also I think I need to
> cater to the DEVLINK=m case since ethtool code is always built in we
> can't use the MAY_USE_DEVLINK trick :S
I think we have to do this:
#if IS_REACHABLE(CONFIG_NET_DEVLINK)
void devlink_compat_running_version(struct net_device *dev,
char *buf, size_t len);
#else
static inline void
devlink_compat_running_version(struct net_device *dev, char *buf, size_t len)
{
}
#endif
Jiri, any objections?
