On Mon, 18 Dec 2006 15:21:11 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote:
> On Mon, 18 Dec 2006 14:56:31 -0800 > [EMAIL PROTECTED] wrote: > > > http://bugzilla.kernel.org/show_bug.cgi?id=7708 > > > > Summary: unregister_netdev() should return unregister_netdevice() > > return code > > Kernel Version: 2.6.19.1 > > Status: NEW > > Severity: low > > Owner: [EMAIL PROTECTED] > > Submitter: [EMAIL PROTECTED] > > > > > > net/core/dev.c:unregister_netdev() function is a wrapper around > > net/core/dev.c:unregister_netdevice(). The unregister_netdevice() function > > returns a return code while unregister_netdev() currently does not. For > > completeness, we should pass the return code from unregister_netdevice() > > all the > > way to the caller. unregister_netdev() should not swallow the return code. > > > > Certainly there's some truth in that ;) > > Is there some reason why you want to test the unregister_netdev() return > value? The only return value is -ENODEV, so I would vote for both just being void -- Stephen Hemminger <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
