Hi, On Tue, 2019-02-26 at 13:38 -0500, Willem de Bruijn wrote: > On Tue, Feb 26, 2019 at 9:28 AM Paolo Abeni <[email protected]> wrote: > > The current implementation for UDP GRO tests is racy: the receiver > > may flush the RX queue while the sending is still transmitting and > > incorrectly report RX errors, with a wrong number of packet received. > > > > Add explicit timeouts to the receiver for both connection activation > > (first packet received for UDP) and reception completion, so that > > in the above critical scenario the receiver will wait for the > > transfer completion. > > > > Fixes: 3327a9c46352 ("selftests: add functionals test for UDP GRO") > > Signed-off-by: Paolo Abeni <[email protected]> > > Acked-by: Willem de Bruijn <[email protected]>
Thanks for reviewing. > --- > > This is because of that "force termination after the second poll()"? Yes, exactly. > Could perhaps also just extend do_recv to wait while (!interrupted && > tnow < tstart + 2000) and avoid the explicit arguments. I thought about that, but then UDP GRO self-tests would take a bit more and the binary helper would be less re-usable for future test cases. Cheers, Paolo
