Hi Toke, I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Toke-H-iland-J-rgensen/xdp-Refactor-devmap-code-in-preparation-for-subsequent-additions/20190301-020259 config: x86_64-randconfig-x016-201908 (attached as .config) compiler: gcc-8 (Debian 8.2.0-21) 8.2.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All warnings (new ones prefixed by >>): In file included from include/linux/bpf-cgroup.h:5, from include/linux/cgroup-defs.h:22, from include/linux/cgroup.h:28, from include/net/netprio_cgroup.h:17, from include/linux/netdevice.h:46, from include/linux/if_vlan.h:15, from include/linux/filter.h:22, from kernel//bpf/core.c:25: include/linux/bpf.h: In function 'dev_map_inc_redirect_count': include/linux/bpf.h:731:1: warning: no return statement in function returning non-void [-Wreturn-type] } ^ include/linux/bpf.h: At top level: >> include/linux/bpf.h:738:13: warning: 'struct bpf_dtab_netdev' declared >> inside parameter list will not be visible outside of this definition or >> declaration struct bpf_dtab_netdev *dst) ^~~~~~~~~~~~~~~ vim +738 include/linux/bpf.h 728 729 static inline int dev_map_inc_redirect_count(void) 730 { > 731 } 732 733 static inline void dev_map_dec_redirect_count(void) 734 { 735 } 736 737 static inline void __dev_map_insert_ctx(struct bpf_map *map, > 738 struct bpf_dtab_netdev *dst) 739 { 740 } 741 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
