From: Mariusz Kozlowski <[EMAIL PROTECTED]> Date: Tue, 2 Jan 2007 11:49:42 +0100
> Hello David, > > > One could argue from a defensive programming perspective that > > this bug comes from the fact that the ifb_init_one() loop > > advances state before checking for errors ('i' is advanced before > > the 'err' check due to the loop construct), and that's why the > > error recovery code had to be coded specially :-) > > Now when I look at it I might be wrong and it is not a bug at all. > It's just coded in weird way. Anyway isn't there kfree(ifbs) missing > on error path? > > The patch below should clear things a bit (against plain 2.6.20-rc2-mm1). > > Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> Ok, I've removed the original patch from my tree. I'll let this cleanup sit for a while so others can review it :-) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html