On 2019/04/13 1:49, Andrey Ignatov wrote:
> Such a check wasn't added since it's already checked in
> inet_dgram_connect, the only place where udpv6_pre_connect is called:
>
> int inet_dgram_connect(struct socket *sock, struct sockaddr *uaddr,
> int addr_len, int flags)
> {
> struct sock *sk = sock->sk;
> int err;
>
> if (addr_len < sizeof(uaddr->sa_family))
> return -EINVAL;
> if (uaddr->sa_family == AF_UNSPEC)
> return sk->sk_prot->disconnect(sk, flags);
>
> if (BPF_CGROUP_PRE_CONNECT_ENABLED(sk)) {
> err = sk->sk_prot->pre_connect(sk, uaddr, addr_len);
> if (err)
> return err;
> }
>
> So it's already handled. But if it helps KMSAN, that's probably fine to
> double-check it here. Or it's considered false positive?
OK, then KMSAN will not complain and this patch can be dropped.
