Harry Coin wrote:
At 10:19 AM 1/15/2007 -0800, Auke Kok wrote:
Have you tried the version in 2.6.19?
I even tried copying and pasting the e100_down and the latest PM stuff
from the newest e100.c version on sourceforge. I admit to being
defeated as to how to join a sourceforge group. Too many hours writing
Microsoft drivers maybe?
the list is open to posting, so that's fairly easy.
It comes down to this:
1) The e100_configure command is the only place that turns off the WOL
disable bit.
2) That bit is only turned off if e100_configure is called after
netif_running is false and wol is set.
3) e100_configure is not called at any point after dev->stop (the first
moment netif_running is false) through the end of .shutdown. Therefore
WOL disable is always turned on, no matter the request by ethtools.
I sense there is a sense that if pci_enable_wake has been called
properly, then all's well. But on this board, there is a configuration
bit that also has to be disabled, a but that is silently reset during a
hw_reset, and hw_reset __is__ called in e100_down.
Hence, the fix I submitted. I know it isn't perfect because I'm not
intimately familiar with the dynamics of this chip. But I do know this:
14 Dell Optiplex systems failed to WOL with the stock 2.6.18 distributed
with debian etch. After my patch is applied to e100.c, and no other
changes from anything default in 2.6.18 and debian etch, it works
perfectly every time. I should have added that ACPI and lapic are in
use, but that's the usual case.
okay, I don't necesary meant that your patch is incorrect, however we need to make sure
that your patch doesn't break 2.6.19, because that code is already upstream.
on top of that, both patches might be needed, and I suspect that is the case to keep
suspend and netconsole to keep working, so I would still like to ask you to test 2.6.19,
with and without your patch.
I'll do the same here and push your patch to Garzik if (after testing) we're both OK
with it.
Thanks,
Auke
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
