On 04/25/2019 10:46 PM, Alexei Starovoitov wrote: > On Wed, Apr 24, 2019 at 09:49:58PM +0200, Paul Chaignon wrote: >> In case of a null check on a pointer inside a subprog, we should mark all >> registers with this pointer as either safe or unknown, in both the current >> and previous frames. Currently, only spilled registers and registers in >> the current frame are marked. Packet bound checks in subprogs have the >> same issue. The first patch fixes it to mark registers in previous frames >> as well. [...] >> >> Changelogs: >> Changes in v3: >> - Fix same issue in find_good_pkt_pointers(). >> - Add test case for find_good_pkt_pointers() issue. >> - Change title to account for the above change. Old title was >> "bpf: mark registers as safe or unknown in all frames". >> - Refactor find_good_pkt_pointers and mark_ptr_or_null_regs.
Sorry for the delay, looks good to me, thanks! >> - I did not keep Yonghong's ack because of the above changes. >> Changes in v2: >> - Fix example codes in commit message. > > Applied to bpf tree, thanks! >
