On Thu, 16 May 2019 13:16:23 +0800, Herbert Xu wrote:
> On Wed, May 15, 2019 at 01:55:01PM -0700, Jakub Kicinski wrote:
> > Since the bit_spin_lock() operations don't actually dereference
> > the pointer, it's fine to forcefully drop the RCU annotation.
> > This fixes 7 sparse warnings per include site.
> >
> > Fixes: 8f0db018006a ("rhashtable: use bit_spin_locks to protect hash
> > bucket.")
> > Signed-off-by: Jakub Kicinski <[email protected]>
> > Reviewed-by: Simon Horman <[email protected]>
>
> I don't think this is the right fix. We should remove the __rcu
> marker from the opaque type rhash_lock_head since it cannot be
> directly dereferenced.
>
> I'm working on a fix to this.
Make sense, anything that clears the warnings is fine with me :)
Thanks!
