On Thu, 16 May 2019 10:41:31 -0700 David Ahern <[email protected]> wrote:
> From: David Ahern <[email protected]> > > The first command in setup_xfrm is failing resulting in the test getting > skipped: > > + ip netns exec ns-B ip -6 xfrm state add src fd00:1::a dst fd00:1::b spi > 0x1000 proto esp aead 'rfc4106(gcm(aes))' > 0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel > + out=RTNETLINK answers: Function not implemented Thanks for fixing this, I ran into this issue right today and I was about to send a patch too. For the record, the quotes went all the way into xfrm_alg_name_match(): name: 'rfc4106(gcm(aes))' entry->name: rfc4106(gcm(aes)) My solution was to remove the single quotes around 'rfc4106(gcm(aes))', but I just checked yours and it also works on bash and dash, so I don't really have a preference. > ... > xfrm6 not supported > TEST: vti6: PMTU exceptions [SKIP] > xfrm4 not supported > TEST: vti4: PMTU exceptions [SKIP] > ... > > The setup command started failing when the run_cmd option was added. > Removing the quotes fixes the problem: > ... > TEST: vti6: PMTU exceptions [ OK ] > TEST: vti4: PMTU exceptions [ OK ] > ... > > Fixes: 56490b623aa0 ("selftests: Add debugging options to pmtu.sh") > Signed-off-by: David Ahern <[email protected]> Reviewed-and-tested-by: Stefano Brivio <[email protected]> -- Stefano
