Re: [RFC PATCH net-next 7/9] net: dsa: Move the phylink driver calls into port.c

[Florian Fainelli]

On 5/22/2019 6:20 PM, Ioana Ciornei wrote:
> In order to have a common handling of PHYLINK for the slave and non-user
> ports, the DSA core glue logic (between PHYLINK and the driver) must use
> an API that does not rely on a struct net_device.
> 
> These will also be called by the CPU-port-handling code in a further
> patch.
> 
> Signed-off-by: Ioana Ciornei <ioana.cior...@nxp.com>
> Suggested-by: Vladimir Oltean <olte...@gmail.com>
> ---

[snip]

> +void dsa_port_phylink_validate(struct dsa_port *dp,
> +                            unsigned long *supported,
> +                            struct phylink_link_state *state)
> +{
> +     struct dsa_switch *ds = dp->ds;
> +
> +     if (!ds->ops->phylink_validate)
> +             return;
> +
> +     ds->ops->phylink_validate(ds, dp->index, supported, state);
> +}
> +EXPORT_SYMBOL(dsa_port_phylink_validate);

Those exports should probably be _GPL to follow the PHYLINK exports but
other than that:

Reviewed-by: Florian Fainelli <f.faine...@gmail.com>
-- 
Florian