On Thu, Jun 13, 2019 at 09:37:51AM +0300, Ioana Ciornei wrote:
> The phy_state field of phylink should carry only valid information
> especially when this can be passed to the .mac_config callback.
> Update the an_enabled field with the autoneg state in the
> phylink_phy_change function.
an_enabled is meaningless to mac_config for PHY mode. Why do you think
this is necessary?
>
> Fixes: 9525ae83959b ("phylink: add phylink infrastructure")
> Signed-off-by: Ioana Ciornei <[email protected]>
> ---
> drivers/net/phy/phylink.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> index 5d0af041b8f9..dd1feb7b5472 100644
> --- a/drivers/net/phy/phylink.c
> +++ b/drivers/net/phy/phylink.c
> @@ -688,6 +688,7 @@ static void phylink_phy_change(struct phy_device *phydev,
> bool up,
> pl->phy_state.pause |= MLO_PAUSE_ASYM;
> pl->phy_state.interface = phydev->interface;
> pl->phy_state.link = up;
> + pl->phy_state.an_enabled = phydev->autoneg;
> mutex_unlock(&pl->state_mutex);
>
> phylink_run_resolve(pl);
> --
> 1.9.1
>
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
