> In msix mode there's no need to explicitly disable completion interrupts, they
> are reliably auto-masked, according to my observations.
> I tested this on two QLE8142 adapters.
>
> Do you have reason to believe this might not always be the case?
How did you check auto-masking of MSI-X interrupts ?
I was just wondering about the below comment in
ql_disable_completion_interrupt(), where for MSI-X it does disable completion
intr for zeroth intr.
Seems special case for zeroth intr in MSI-X particular to this device.
/* HW disables for us if we're MSIX multi interrupts and
* it's not the default (zeroeth) interrupt.
*/
if (likely(test_bit(QL_MSIX_ENABLED, &qdev->flags) && intr))
return 0;
