Hi Allan, > -----Original Message----- > From: Allan W . Nielsen <allan.niel...@microchip.com> > Sent: Wednesday, August 14, 2019 5:17 PM > To: Y.b. Lu <yangbo...@nxp.com> > Cc: Andrew Lunn <and...@lunn.ch>; netdev@vger.kernel.org; David S . Miller > <da...@davemloft.net>; Alexandre Belloni <alexandre.bell...@bootlin.com>; > Microchip Linux Driver Support <unglinuxdri...@microchip.com> > Subject: Re: [v2, 4/4] ocelot: add VCAP IS2 rule to trap PTP Ethernet frames > > The 08/14/2019 04:56, Y.b. Lu wrote: > > > -----Original Message----- > > > From: Allan W . Nielsen <allan.niel...@microchip.com> > > > Sent: Tuesday, August 13, 2019 2:25 PM > > > To: Y.b. Lu <yangbo...@nxp.com> > > > Cc: netdev@vger.kernel.org; David S . Miller <da...@davemloft.net>; > > > Alexandre Belloni <alexandre.bell...@bootlin.com>; Microchip Linux > > > Driver Support <unglinuxdri...@microchip.com> > > > Subject: Re: [v2, 4/4] ocelot: add VCAP IS2 rule to trap PTP > > > Ethernet frames > > > > > > The 08/13/2019 10:52, Yangbo Lu wrote: > > > > All the PTP messages over Ethernet have etype 0x88f7 on them. > > > > Use etype as the key to trap PTP messages. > > > > > > > > Signed-off-by: Yangbo Lu <yangbo...@nxp.com> [...] > Can we continue this discussion in the other thread where I listed the 3 > scenarios?
[Y.b. Lu] Sure. Let's discuss in that thread. https://patchwork.ozlabs.org/patch/1145627/ [...] > > > What if do not want this on all ports? > > [Y.b. Lu] Actually I don’t think there should be difference of handling PTP > messages on each port. > > You don’t need to run PTP protocol application on the specific port if you > don’t want. > What if you want some vlans or some ports to be PTP unaware, and other to > be PTP aware. [Y.b. Lu] Actually I couldn’t find reasons why make some ports PTP unaware, if there is software stack for PTP aware... > > > > If you do not have an application behind this implementing a > > > boundary or transparent clock, then you are breaking PTP on the network. > > [Y.b. Lu] You're right. But actually for PTP network, all PTP devices > > should run > PTP protocol on it. > > Of course, it's better to have a way to configure it as non-aware PTP > > switch. > I think we agree. > > In my point of view, it is the PTP daemon who should configure frames to be > trapped. Then the switch will be PTP unaware until the PTP daemon starts up > and is ready to make it aware. > > If we put it in the init function, then it will be of PTP broken until the PTP > daemon starts. > > /Allan
